Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

8276848: sun.net.httpserver.simpleserver.CommandLinePositiveTest: test does not specify port #6361

Closed
wants to merge 2 commits into from
Closed

8276848: sun.net.httpserver.simpleserver.CommandLinePositiveTest: test does not specify port #6361

wants to merge 2 commits into from

Conversation

FrauBoes
Copy link
Member

@FrauBoes FrauBoes commented Nov 11, 2021 •
edited by openjdk bot

This change corrects the server configuration in testBindAllInterfaces to specify the port. Additionally, a manual test is added for the case where the port is not specified and the server uses the default port 8000, which might already be in use by another test. To avoid this scenario and the resulting BindException, the test is made manual.

Testing: Tier 1-3

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8276848: sun.net.httpserver.simpleserver.CommandLinePositiveTest: test does not specify port

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6361/head:pull/6361
$ git checkout pull/6361

Update a local copy of the PR:
$ git checkout pull/6361
$ git pull https://git.openjdk.java.net/jdk pull/6361/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6361

View PR using the GUI difftool:
$ git pr show -t 6361

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6361.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 11, 2021

👋 Welcome back jboes! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 11, 2021
@openjdk
Copy link

openjdk bot commented Nov 11, 2021

@FrauBoes The following label will be automatically applied to this pull request:

  • net

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the net net-dev@openjdk.org label Nov 11, 2021
@mlbridge
Copy link

mlbridge bot commented Nov 11, 2021 •
edited

Webrevs

dfuch
dfuch approved these changes Nov 11, 2021
View reviewed changes
Copy link
Member

@dfuch dfuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openjdk
Copy link

openjdk bot commented Nov 11, 2021 •
edited

@FrauBoes This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8276848: sun.net.httpserver.simpleserver.CommandLinePositiveTest: test does not specify port

Reviewed-by: dfuchs

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 55 new commits pushed to the master branch:

  • 6b833db: 8275329: ZGC: vmTestbase/gc/gctests/SoftReference/soft004/soft004.java fails with assert(_phases->length() <= 1000) failed: Too many recored phases?
  • 1e941de: 8275197: Remove unused fields in ThaiBuddhistChronology
  • 6954b98: 8186670: Implement _onSpinWait() intrinsic for AArch64
  • 3445e50: 8276265: jcmd man page is outdated
  • 0ca0acf: 8276947: Clarify how DateTimeFormatterBuilder.appendFraction handles value ranges
  • b0d7a9d: 8276994: java/nio/channels/Channels/TransferTo.java leaves multi-GB files in /tmp
  • 8aae88b: 8276763: java/nio/channels/SocketChannel/AdaptorStreams.java fails with "SocketTimeoutException: Read timed out"
  • 6f35eed: 8079267: [TEST_BUG] Test java/awt/Frame/MiscUndecorated/RepaintTest.java fails
  • 5e98f99: 8276800: Fix table headers in NumericShaper.html
  • 2ca4ff8: 8244202: Implementation of JEP 418: Internet-Address Resolution SPI
  • ... and 45 more: https://git.openjdk.java.net/jdk/compare/8747882e4cb3af58062923bf830f9de877bdb03d...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 11, 2021
@jaikiran
Copy link
Member

Hello Julia,
Is it intentional that this new manual test and the existing tests in "simpleserver" don't have a @bug id noted on their test definition?

@FrauBoes
Copy link
Member Author

Is it intentional that this new manual test and the existing tests in "simpleserver" don't have a @bug id noted on their test definition?

I don't think the @bug tag is necessary for tests that are added as part of a JEP, but I added it for the new manual test. Thanks!

@jaikiran
Copy link
Member

Thank you, I didn't know that.

@FrauBoes
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Nov 12, 2021

Going to push as commit 13deb38.
Since your change was applied there have been 56 commits pushed to the master branch:

  • 710f496: 8273277: C2: Move conditional negation into rc_predicate
  • 6b833db: 8275329: ZGC: vmTestbase/gc/gctests/SoftReference/soft004/soft004.java fails with assert(_phases->length() <= 1000) failed: Too many recored phases?
  • 1e941de: 8275197: Remove unused fields in ThaiBuddhistChronology
  • 6954b98: 8186670: Implement _onSpinWait() intrinsic for AArch64
  • 3445e50: 8276265: jcmd man page is outdated
  • 0ca0acf: 8276947: Clarify how DateTimeFormatterBuilder.appendFraction handles value ranges
  • b0d7a9d: 8276994: java/nio/channels/Channels/TransferTo.java leaves multi-GB files in /tmp
  • 8aae88b: 8276763: java/nio/channels/SocketChannel/AdaptorStreams.java fails with "SocketTimeoutException: Read timed out"
  • 6f35eed: 8079267: [TEST_BUG] Test java/awt/Frame/MiscUndecorated/RepaintTest.java fails
  • 5e98f99: 8276800: Fix table headers in NumericShaper.html
  • ... and 46 more: https://git.openjdk.java.net/jdk/compare/8747882e4cb3af58062923bf830f9de877bdb03d...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Nov 12, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 12, 2021
@openjdk
Copy link

openjdk bot commented Nov 12, 2021

@FrauBoes Pushed as commit 13deb38.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@FrauBoes FrauBoes deleted the sws-test-fix branch November 12, 2021 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dfuch dfuch dfuch approved these changes

Assignees
No one assigned
Labels
integrated Pull request has been integrated net net-dev@openjdk.org
Milestone
No milestone
3 participants
@FrauBoes @jaikiran @dfuch